fix: condition on target instead of exec#3373
Merged
Conversation
thesayyn
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
thesayyn
force-pushed
the
nodejs_image_fix
branch
from
3b27364 to
7ca6f7e
Compare
Collaborator
Author
|
I will add container image structure tests to ensure that this type of error never goes unnoticed. |
alexeagle
approved these changes
Mar 29, 2022
Collaborator
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
Neat, we should do a follow-up to add some comments about how the ordering matters (linux target toolchain must be declared before non-linux host toolchain) but can be after shipping a release, which I want to do now :)
| if register: | ||
| native.register_toolchains("@%s_toolchains//:%s_toolchain" % (name, platform)) | ||
| native.register_toolchains( | ||
| "@%s_toolchains//:%s_toolchain_target" % (name, platform), |
Collaborator
There was a problem hiding this comment.
comment that this one needs to be first so it's resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3357
What is the new behavior?
nodejs toolchain was conditioned on the exec which led to nodejs_images using toolchain for the host instead of image target. hence images built from macOS were broken due to the wrong toolchain being used in runfiles.
Does this PR introduce a breaking change?
Other information
Related issues;
bazelbuild/rules_docker#2009
bazelbuild/rules_docker#1963