Add index of packages in jar files when pinning#716
Merged
shs96c merged 3 commits intobazel-contrib:masterfrom Jul 5, 2022
Merged
Add index of packages in jar files when pinning#716shs96c merged 3 commits intobazel-contrib:masterfrom
shs96c merged 3 commits intobazel-contrib:masterfrom
Conversation
shs96c
reviewed
Jul 5, 2022
This allows other tooling, e.g. gazelle, to make use of this information. This can be useful for dependency inference, dependency analysis, and suggesting missing dependencies. This makes sense to do at pin time because the lifecycle of this information is closely tied to the artifacts being fetched/pinned. Generating the information is cheap enough that this shouldn't significantly slow down pins, but is expensive enough that other tooling may want to avoid doing so on the fly at runtime, so is useful to cache.
It contains the vast majority of the implementation of the ruleset
shs96c
approved these changes
Jul 5, 2022
Collaborator
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
One small nit, then it's good to go
shs96c
approved these changes
Jul 5, 2022
Collaborator
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
CI builds are passing, and the changes to the lock files seem fine. LGTM
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this pull request
Jul 5, 2022
bazel-contrib/rules_jvm_external#716 started indexing jar files and adding the package index to the maven_install.json. This re-uses that data, rather than re-implementing parsing ourselves. This has the advantage of no longer needing to check in and manage the lifecycle of an additional cache file, and deletes a bunch of code.
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this pull request
Jul 5, 2022
bazel-contrib/rules_jvm_external#716 started indexing jar files and adding the package index to the maven_install.json. This re-uses that data, rather than re-implementing parsing ourselves. This has the advantage of no longer needing to check in and manage the lifecycle of an additional cache file, and deletes a bunch of code.
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this pull request
Jul 6, 2022
bazel-contrib/rules_jvm_external#716 started indexing jar files and adding the package index to the maven_install.json. This re-uses that data, rather than re-implementing parsing ourselves. This has the advantage of no longer needing to check in and manage the lifecycle of an additional cache file, and deletes a bunch of code.
illicitonion
added a commit
to bazel-contrib/rules_jvm
that referenced
this pull request
Jul 6, 2022
bazel-contrib/rules_jvm_external#716 started indexing jar files and adding the package index to the maven_install.json. This re-uses that data, rather than re-implementing parsing ourselves. This has the advantage of no longer needing to check in and manage the lifecycle of an additional cache file, and deletes a bunch of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows other tooling, e.g. gazelle, to make use of this
information. This can be useful for dependency inference, dependency
analysis, and suggesting missing dependencies.
This makes sense to do at pin time because the lifecycle of this
information is closely tied to the artifacts being fetched/pinned.
Generating the information is cheap enough that this shouldn't
significantly slow down pins, but is expensive enough that other tooling
may want to avoid doing so on the fly at runtime, so is useful to cache.