Hi wonderful Bazel folks,
I'd noticed that Bazel core was ignoring ProGuard files embedded in JARs, rather than bubbling them up in ProguardSpecProvider, so I'd pulled together a PR to fix it bazelbuild/bazel#14966.
But that doesn't automatically fix the issue in this repo, since it looks like rules_jvm_external rolls its own java_import, java_import having been badly broken for Kotlin for years. Sad times.
So, I thought I should give a heads, especially since the majority of JARs with these embedded ProGuard specs are probably being pulled from Maven. It seems like the right fix is probably to fix java_import and use that, rather than getting deeper into duplicating its essential logic. But you could also re-roll all the java_import proguard logic in jvm_import, using on the extractor tool I wrote in the PR (once it lands) and the Bazel proguard spec validator already available. Thoughts?
Thanks for reading,
Chris
(ex-Googler)
Hi wonderful Bazel folks,
I'd noticed that Bazel core was ignoring ProGuard files embedded in JARs, rather than bubbling them up in ProguardSpecProvider, so I'd pulled together a PR to fix it bazelbuild/bazel#14966.
But that doesn't automatically fix the issue in this repo, since it looks like rules_jvm_external rolls its own java_import, java_import having been badly broken for Kotlin for years. Sad times.
So, I thought I should give a heads, especially since the majority of JARs with these embedded ProGuard specs are probably being pulled from Maven. It seems like the right fix is probably to fix java_import and use that, rather than getting deeper into duplicating its essential logic. But you could also re-roll all the java_import proguard logic in jvm_import, using on the extractor tool I wrote in the PR (once it lands) and the Bazel proguard spec validator already available. Thoughts?
Thanks for reading,
Chris
(ex-Googler)