Use rules_jvm_external install for package index#49
Merged
illicitonion merged 1 commit intobazel-contrib:mainfrom Jul 6, 2022
Merged
Conversation
stevebarrau
approved these changes
Jul 6, 2022
Collaborator
stevebarrau
left a comment
stevebarrau
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up @illicitonion ✨
bazel-contrib/rules_jvm_external#716 started indexing jar files and adding the package index to the maven_install.json. This re-uses that data, rather than re-implementing parsing ourselves. This has the advantage of no longer needing to check in and manage the lifecycle of an additional cache file, and deletes a bunch of code.
illicitonion
force-pushed
the
load-packages-from-maven-install
branch
from
0f77a7e to
40287fd
Compare
shs96c
approved these changes
Jul 6, 2022
Collaborator
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
Rubber stamping. Perhaps we should note that you need a specific version of rules_jvm_external for this to work?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazel-contrib/rules_jvm_external#716 started
indexing jar files and adding the package index to the
maven_install.json.
This re-uses that data, rather than re-implementing parsing ourselves.
This has the advantage of no longer needing to check in and manage the
lifecycle of an additional cache file, and deletes a bunch of code.