Support python runfiles MANIFEST on windows#2868
Merged
jayconrod merged 3 commits intobazel-contrib:masterfrom May 14, 2021
Merged
Support python runfiles MANIFEST on windows#2868jayconrod merged 3 commits intobazel-contrib:masterfrom
jayconrod merged 3 commits intobazel-contrib:masterfrom
Conversation
These manifests can have entries like `__init.py__ ` with no value at the end for the actual path of the runfile. closes bazel-contrib#2866
Contributor
Author
|
Passing external run in reproduction repository using |
samhowes
changed the title
samhowes
commented
Apr 17, 2021
|
|
||
| err = ioutil.WriteFile("MANIFEST", | ||
| // all on one line to make sure the whitespace stays exactly as in the source file | ||
| []byte("__init__.py \n__main__/external/__init__.py \n__main__/external/rules_python/__init__.py \n__main__/external/rules_python/python/__init__.py \n__main__/external/rules_python/python/runfiles/__init__.py \n__main__/external/rules_python/python/runfiles/runfiles.py C:/users/sam/_bazel_sam/pj4cl7d4/external/rules_python/python/runfiles/runfiles.py\n__main__/go_cat_/go_cat.exe C:/users/sam/_bazel_sam/pj4cl7d4/execroot/__main__/bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/go_cat_/go_cat.exe\n__main__/important.txt C:/users/sam/dev/rules_go_runfiles_repro/important.txt\n__main__/parent.exe C:/users/sam/_bazel_sam/pj4cl7d4/execroot/__main__/bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/parent.exe\n__main__/parent.py C:/users/sam/dev/rules_go_runfiles_repro/parent.py\n__main__/parent.zip C:/users/sam/_bazel_sam/pj4cl7d4/execroot/__main__/bazel-out/x64_windows-opt-exec-2B5CBBC6/bin/parent.zip\nrules_python/__init__.py \nrules_python/python/__init__.py \nrules_python/python/runfiles/__init__.py \nrules_python/python/runfiles/runfiles.py C:/users/sam/_bazel_sam/pj4cl7d4/external/rules_python/python/runfiles/runfiles.py"), |
Contributor
Author
There was a problem hiding this comment.
I can understand reducing this to just a couple lines of relevant entries, I thought it might be helpful to see an exact reproduction of the issue though. This was a full copy-paste from a generated manifest file on my machine.
jayconrod
approved these changes
May 14, 2021
Collaborator
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing this.
Locating runfiles has been a major pain. There are so many different variations. I wasn't aware at all that Python had different behavior.
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…l-contrib#2699) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.3 to 2.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>2.3.0</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Features</h2> <ul> <li>Added <code>HTTPResponse.shutdown()</code> to stop any ongoing or future reads for a specific response. It calls <code>shutdown(SHUT_RD)</code> on the underlying socket. This feature was <a href="https://opencollective.com/urllib3/contributions/815307">sponsored by LaunchDarkly</a>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2868">urllib3/urllib3#2868</a>)</li> <li>Added support for JavaScript Promise Integration on Emscripten. This enables more efficient WebAssembly requests and streaming, and makes it possible to use in Node.js if you launch it as node <code>--experimental-wasm-stack-switching</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3400">urllib3/urllib3#3400</a>)</li> <li>Added the <code>proxy_is_tunneling</code> property to <code>HTTPConnection</code> and <code>HTTPSConnection</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3285">urllib3/urllib3#3285</a>)</li> <li>Added pickling support to <code>NewConnectionError</code> and <code>NameResolutionError</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3480">urllib3/urllib3#3480</a>)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Fixed an issue in debug logs where the HTTP version was rendering as "HTTP/11" instead of "HTTP/1.1". (<a href="https://redirect.github.com/urllib3/urllib3/issues/3489">urllib3/urllib3#3489</a>)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Removed support for Python 3.8. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3492">urllib3/urllib3#3492</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0">https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>2.3.0 (2024-12-22)</h1> <h2>Features</h2> <ul> <li>Added <code>HTTPResponse.shutdown()</code> to stop any ongoing or future reads for a specific response. It calls <code>shutdown(SHUT_RD)</code> on the underlying socket. This feature was <code>sponsored by LaunchDarkly <https://opencollective.com/urllib3/contributions/815307></code><strong>. (<code>[bazel-contrib#2868](urllib3/urllib3#2868) <https://github.com/urllib3/urllib3/issues/2868></code></strong>)</li> <li>Added support for JavaScript Promise Integration on Emscripten. This enables more efficient WebAssembly requests and streaming, and makes it possible to use in Node.js if you launch it as <code>node --experimental-wasm-stack-switching</code>. (<code>[bazel-contrib#3400](urllib3/urllib3#3400) <https://github.com/urllib3/urllib3/issues/3400></code>__)</li> <li>Added the <code>proxy_is_tunneling</code> property to <code>HTTPConnection</code> and <code>HTTPSConnection</code>. (<code>[bazel-contrib#3285](urllib3/urllib3#3285) <https://github.com/urllib3/urllib3/issues/3285></code>__)</li> <li>Added pickling support to <code>NewConnectionError</code> and <code>NameResolutionError</code>. (<code>[bazel-contrib#3480](urllib3/urllib3#3480) <https://github.com/urllib3/urllib3/issues/3480></code>__)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Fixed an issue in debug logs where the HTTP version was rendering as "HTTP/11" instead of "HTTP/1.1". (<code>[bazel-contrib#3489](urllib3/urllib3#3489) <https://github.com/urllib3/urllib3/issues/3489></code>__)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Removed support for Python 3.8. (<code>[bazel-contrib#3492](urllib3/urllib3#3492) <https://github.com/urllib3/urllib3/issues/3492></code>__)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/2f68c5363ef632d73dd4d9300289d7ce5ff275b4"><code>2f68c53</code></a> Release 2.3.0</li> <li><a href="https://github.com/urllib3/urllib3/commit/f7bcf6986fa9c43fc7884b648f66688db593b491"><code>f7bcf69</code></a> Add HTTPResponse.shutdown() to stop blocking reads (<a href="https://redirect.github.com/urllib3/urllib3/issues/3527">#3527</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/e94224931feddf9e12bb25452bf0d0c21da8a7e0"><code>e942249</code></a> Update .readthedocs.yml addressing a deprecation (<a href="https://redirect.github.com/urllib3/urllib3/issues/3534">#3534</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/905549d64a948abd4b6962edecb8dd5569166275"><code>905549d</code></a> Upgrade Python pre-commit tools (<a href="https://redirect.github.com/urllib3/urllib3/issues/3529">#3529</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/716d8340b89f7d8ec549579d14e3c0a7e5f859a5"><code>716d834</code></a> Fix PyPI publish with Core metadata 2.4 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3531">#3531</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/7ab935c6ddd546c7d57b03c0269685c61c8e60c6"><code>7ab935c</code></a> Address zizmor issues</li> <li><a href="https://github.com/urllib3/urllib3/commit/181357ed2aecf9c523f2664c05f176cde9692994"><code>181357e</code></a> Bump Quart to fix CI (<a href="https://redirect.github.com/urllib3/urllib3/issues/3524">#3524</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/0e7e0df0586573d51c78076d4871050783bec7c8"><code>0e7e0df</code></a> Start testing with Python 3.14</li> <li><a href="https://github.com/urllib3/urllib3/commit/d67d09bfd04ecdae1280a563d06b32949befaf71"><code>d67d09b</code></a> Bump mypy version</li> <li><a href="https://github.com/urllib3/urllib3/commit/20032ec38a09680bcfb6d97b4c43b276af43cc64"><code>20032ec</code></a> Drop unneeded dependency pins and a warning filter</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…#2698) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.3 to 2.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>2.3.0</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Features</h2> <ul> <li>Added <code>HTTPResponse.shutdown()</code> to stop any ongoing or future reads for a specific response. It calls <code>shutdown(SHUT_RD)</code> on the underlying socket. This feature was <a href="https://opencollective.com/urllib3/contributions/815307">sponsored by LaunchDarkly</a>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2868">urllib3/urllib3#2868</a>)</li> <li>Added support for JavaScript Promise Integration on Emscripten. This enables more efficient WebAssembly requests and streaming, and makes it possible to use in Node.js if you launch it as node <code>--experimental-wasm-stack-switching</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3400">urllib3/urllib3#3400</a>)</li> <li>Added the <code>proxy_is_tunneling</code> property to <code>HTTPConnection</code> and <code>HTTPSConnection</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3285">urllib3/urllib3#3285</a>)</li> <li>Added pickling support to <code>NewConnectionError</code> and <code>NameResolutionError</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3480">urllib3/urllib3#3480</a>)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Fixed an issue in debug logs where the HTTP version was rendering as "HTTP/11" instead of "HTTP/1.1". (<a href="https://redirect.github.com/urllib3/urllib3/issues/3489">urllib3/urllib3#3489</a>)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Removed support for Python 3.8. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3492">urllib3/urllib3#3492</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0">https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>2.3.0 (2024-12-22)</h1> <h2>Features</h2> <ul> <li>Added <code>HTTPResponse.shutdown()</code> to stop any ongoing or future reads for a specific response. It calls <code>shutdown(SHUT_RD)</code> on the underlying socket. This feature was <code>sponsored by LaunchDarkly <https://opencollective.com/urllib3/contributions/815307></code><strong>. (<code>[bazel-contrib#2868](urllib3/urllib3#2868) <https://github.com/urllib3/urllib3/issues/2868></code></strong>)</li> <li>Added support for JavaScript Promise Integration on Emscripten. This enables more efficient WebAssembly requests and streaming, and makes it possible to use in Node.js if you launch it as <code>node --experimental-wasm-stack-switching</code>. (<code>[bazel-contrib#3400](urllib3/urllib3#3400) <https://github.com/urllib3/urllib3/issues/3400></code>__)</li> <li>Added the <code>proxy_is_tunneling</code> property to <code>HTTPConnection</code> and <code>HTTPSConnection</code>. (<code>[bazel-contrib#3285](urllib3/urllib3#3285) <https://github.com/urllib3/urllib3/issues/3285></code>__)</li> <li>Added pickling support to <code>NewConnectionError</code> and <code>NameResolutionError</code>. (<code>[bazel-contrib#3480](urllib3/urllib3#3480) <https://github.com/urllib3/urllib3/issues/3480></code>__)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Fixed an issue in debug logs where the HTTP version was rendering as "HTTP/11" instead of "HTTP/1.1". (<code>[bazel-contrib#3489](urllib3/urllib3#3489) <https://github.com/urllib3/urllib3/issues/3489></code>__)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Removed support for Python 3.8. (<code>[bazel-contrib#3492](urllib3/urllib3#3492) <https://github.com/urllib3/urllib3/issues/3492></code>__)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/2f68c5363ef632d73dd4d9300289d7ce5ff275b4"><code>2f68c53</code></a> Release 2.3.0</li> <li><a href="https://github.com/urllib3/urllib3/commit/f7bcf6986fa9c43fc7884b648f66688db593b491"><code>f7bcf69</code></a> Add HTTPResponse.shutdown() to stop blocking reads (<a href="https://redirect.github.com/urllib3/urllib3/issues/3527">#3527</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/e94224931feddf9e12bb25452bf0d0c21da8a7e0"><code>e942249</code></a> Update .readthedocs.yml addressing a deprecation (<a href="https://redirect.github.com/urllib3/urllib3/issues/3534">#3534</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/905549d64a948abd4b6962edecb8dd5569166275"><code>905549d</code></a> Upgrade Python pre-commit tools (<a href="https://redirect.github.com/urllib3/urllib3/issues/3529">#3529</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/716d8340b89f7d8ec549579d14e3c0a7e5f859a5"><code>716d834</code></a> Fix PyPI publish with Core metadata 2.4 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3531">#3531</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/7ab935c6ddd546c7d57b03c0269685c61c8e60c6"><code>7ab935c</code></a> Address zizmor issues</li> <li><a href="https://github.com/urllib3/urllib3/commit/181357ed2aecf9c523f2664c05f176cde9692994"><code>181357e</code></a> Bump Quart to fix CI (<a href="https://redirect.github.com/urllib3/urllib3/issues/3524">#3524</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/0e7e0df0586573d51c78076d4871050783bec7c8"><code>0e7e0df</code></a> Start testing with Python 3.14</li> <li><a href="https://github.com/urllib3/urllib3/commit/d67d09bfd04ecdae1280a563d06b32949befaf71"><code>d67d09b</code></a> Bump mypy version</li> <li><a href="https://github.com/urllib3/urllib3/commit/20032ec38a09680bcfb6d97b4c43b276af43cc64"><code>20032ec</code></a> Drop unneeded dependency pins and a warning filter</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/2.2.3...2.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR fixes compatibility with a MANIFEST file generated for a rules_python binary. Python manifests can have "one-part" entries like
__init__.pywhere a line terminates with a space and does not map to another file.Which issues(s) does this PR fix?
Fixes #2866
Other notes for review
I wasn't sure about how exactly this fix should be tested. I think the "proper" test is actually an integration test as written over in https://github.com/samhowes/rules_go_runfiles_repro/blob/main/BUILD.bazel since this issue is really dependent on bazel's generation of a MANIFEST for python
__init__.pymodules (see comment on runfiles_test.py). Since this repository does not currently have a (declared) dep onrules_python, I did not bring that test over here.