Skip to content

Calling go_register_toolchains(version) twice causes a failure #2761

@rgs1

Description

@rgs1

rules_docker breaks for us after updating to rules_go 0.25.0, though this patch fixes it for us:

bazelbuild/rules_docker#1700

The problem is that in our setup, go_register_toolchains() gets called more than once. Simply passing the version isn't a
solution, since after the first call an sdk rule becomes available and then we hit:

go_register_toolchains: version set after go sdk rule declared

Would it be ok to have go_register_toolchains() return gracefully when an sdk is available do to a previous call instead of failing here:

https://github.com/bazelbuild/rules_go/blob/master/go/private/sdk.bzl#L405

?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions