Map embedded resource names like MSBuild #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sin-ack
force-pushed
the
embedded-resource-names
branch
2 times, most recently
from
f685992 to
8141c89
Compare
MSBuild maps the file names as "{project name}.{dotted path}" where
the project name is the same as the final generated assembly name and
the dotted path is the project-relative path to the embedded resource
with slashes changed to periods. Without this, the resource only gets
embedded with its basename in the manifest which breaks expectations
compared to MSBuild.
sin-ack
force-pushed
the
embedded-resource-names
branch
from
8141c89 to
7ae2a8c
Compare
Contributor
Author
|
Updated to match what MSBuild does. Undrafting PR as the issue seems to be approved. |
sin-ack
force-pushed
the
embedded-resource-names
branch
from
7ae2a8c to
d28ddb9
Compare
purkhusid
approved these changes
Mar 17, 2025
Collaborator
purkhusid
left a comment
purkhusid
left a comment
There was a problem hiding this comment.
Nice! Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSBuild maps the file names as "{project name}.{dotted path}" where the project name is the same as the final generated assembly name and the dotted path is the project-relative path to the embedded resource with slashes changed to periods. Without this, the resource only gets embedded with its basename in the manifest which breaks expectations compared to MSBuild.
Fixes #474.
Drafted since the I haven't received a response on the issue yet. If the solution is acceptable, I will undraft the PR.