ci(pre-commit): Enable pre-commit CI and renovate#130
Merged
alexeagle merged 3 commits intobazel-contrib:mainfrom Dec 17, 2024
Merged
ci(pre-commit): Enable pre-commit CI and renovate#130alexeagle merged 3 commits intobazel-contrib:mainfrom
alexeagle merged 3 commits intobazel-contrib:mainfrom
Conversation
fmeum
approved these changes
Dec 9, 2024
Member
alexeagle
approved these changes
Dec 9, 2024
Contributor
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
I think it looks good, but let's land your bazel-lib usage of it and get a few days usage to verify it behaves how rules authors will want, before we update the template.
Contributor
Author
Sounds good. I pushed another commit fixing all pre-commit issues so that we can merge in a few days. |
Contributor
Author
|
@alexeagle Having this merged in https://github.com/bazel-contrib/bazel-lib for a week seems to work. Should we add this to the template as well? |
Contributor
|
Yes, SGTM thanks for following up. |
alexeagle
pushed a commit
to aspect-build/rules_py
that referenced
this pull request
Jan 23, 2025
Follow up of #474 running buildifier on all files. A follow up PR will fix the remaining `buildifier-lint` warnings and add pre-commit to CI similar to bazel-contrib/rules-template#130. Co-authored-by: Alex Eagle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the rules already prvide a pre-commit config, we should also make sure the checks pass CI and hooks stay up to date.