Skip to content

fix: declare COREUTILS_TOOLCHAIN as a Label()#1244

Merged
jbedard merged 1 commit intobazel-contrib:mainfrom
jbedard:coreutils-label
Feb 26, 2026
Merged

fix: declare COREUTILS_TOOLCHAIN as a Label()#1244
jbedard merged 1 commit intobazel-contrib:mainfrom
jbedard:coreutils-label

Conversation

@jbedard
Copy link
Copy Markdown
Collaborator

@jbedard jbedard commented Feb 26, 2026 •
edited
Loading

When this is referenced by the public COPY_FILE_TOOLCHAINS in lib/copy_file.bzl it may be passed along to a rule invocation that does not directly depend on bazel_lib.

For example:
aspect_rules_jest => aspect_rules_js (v3) => bazel_lib
while aspect_rules_jest only directly depends on v2 (aspect_bazel_lib)

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows bot commented Feb 26, 2026 •
edited
Loading

Bazel 8 (Test)

2 test targets passed

Targets 
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]                    46ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild]                 40ms

Total test execution time was 86ms. 135 tests (98.5%) were fully cached saving 16s.

Bazel 9 (Test)

2 test targets passed

Targets 
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]                    53ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild]                 79ms

Total test execution time was 132ms. 135 tests (98.5%) were fully cached saving 18s.

Bazel 7 (Test)

e2e/api_entries

All tests were cache hits

1 test (100.0%) was fully cached saving 24ms.

Bazel 8 (Test)

e2e/api_entries

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 9 (Test)

e2e/api_entries

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Bazel 7 (Test)

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 8 (Test)

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Bazel 9 (Test)

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 297ms.

Bazel 8 (Test)

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 286ms.

Bazel 9 (Test)

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 349ms.

Bazel 7 (Test)

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 247ms.

Bazel 8 (Test)

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 216ms.

Bazel 9 (Test)

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 198ms.

Bazel 7 (Test)

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 8 (Test)

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Bazel 9 (Test)

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/smoke

All tests were cache hits

4 tests (100.0%) were fully cached saving 611ms.

Bazel 8 (Test)

e2e/smoke

All tests were cache hits

4 tests (100.0%) were fully cached saving 508ms.

Bazel 9 (Test)

e2e/smoke

All tests were cache hits

4 tests (100.0%) were fully cached saving 618ms.

Bazel 7 (Test)

e2e/write_source_files

All tests were cache hits

1 test (100.0%) was fully cached saving 39ms.

Bazel 8 (Test)

e2e/write_source_files

All tests were cache hits

1 test (100.0%) was fully cached saving 33ms.

Bazel 9 (Test)

e2e/write_source_files

All tests were cache hits

1 test (100.0%) was fully cached saving 40ms.

@jbedard jbedard marked this pull request as ready for review February 26, 2026 02:35
@jbedard jbedard requested a review from alexeagle February 26, 2026 02:35
@jbedard jbedard merged commit cac2d78 into bazel-contrib:main Feb 26, 2026
22 checks passed
@jbedard jbedard deleted the coreutils-label branch February 26, 2026 03:04
@jbedard jbedard mentioned this pull request Mar 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @alexeagle