Skip to content

fix(2.x): alias copy_directory_bin_action to bazel_lib#1229

Merged
jbedard merged 1 commit intobazel-contrib:2.xfrom
jbedard:copy_attrs_alt
Jan 9, 2026
Merged

fix(2.x): alias copy_directory_bin_action to bazel_lib#1229
jbedard merged 1 commit intobazel-contrib:2.xfrom
jbedard:copy_attrs_alt

Conversation

@jbedard
Copy link
Copy Markdown
Collaborator

@jbedard jbedard commented Jan 8, 2026 •
edited
Loading

So 2.x does not need to refer to the private COPY_EXECUTION_REQUIREMENTS.

@jbedard jbedard requested a review from alexeagle January 8, 2026 23:10
@jbedard jbedard force-pushed the copy_attrs_alt branch 2 times, most recently from 347c86b to dad100b Compare January 9, 2026 00:23
@jbedard jbedard mentioned this pull request Jan 9, 2026
Merged
@jbedard jbedard force-pushed the copy_attrs_alt branch 2 times, most recently from 251ea4f to 482153a Compare January 9, 2026 00:34
@jbedard jbedard requested a review from alexeagle January 9, 2026 00:38
@jbedard jbedard force-pushed the copy_attrs_alt branch 2 times, most recently from 5838d5d to 6f54370 Compare January 9, 2026 00:53
@jbedard jbedard merged commit 056e03d into bazel-contrib:2.x Jan 9, 2026
25 of 77 checks passed
@jbedard jbedard deleted the copy_attrs_alt branch January 9, 2026 19:19
@Silic0nS0ldier
Copy link
Copy Markdown

Silic0nS0ldier commented Jan 10, 2026

Something about this change is causing issues for @aspect_rules_ts.

@Silic0nS0ldier ➜ /workspaces/vscode-git-monolithic-extension (renovate/aspect_bazel_lib-2.x) $ bazel build //:tsconfig
ERROR: no such package '@@[unknown repo 'bazel_lib' requested from @@aspect_rules_ts+ (did you mean 'bazel_skylib'?)]//lib': The repository '@@[unknown repo 'bazel_lib' requested from @@aspect_rules_ts+ (did you mean 'bazel_skylib'?)]' could not be resolved: No repository visible as '@bazel_lib' from repository '@@aspect_rules_ts+'
ERROR: /workspaces/vscode-git-monolithic-extension/BUILD.bazel:7:10: While resolving toolchains for target //:tsconfig (0fee1dd): com.google.devtools.build.lib.packages.BuildFileNotFoundException: no such package '@@[unknown repo 'bazel_lib' requested from @@aspect_rules_ts+ (did you mean 'bazel_skylib'?)]//lib': The repository '@@[unknown repo 'bazel_lib' requested from @@aspect_rules_ts+ (did you mean 'bazel_skylib'?)]' could not be resolved: No repository visible as '@bazel_lib' from repository '@@aspect_rules_ts+'
ERROR: Analysis of target '//:tsconfig' failed; build aborted
INFO: Elapsed time: 0.200s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully

See also https://github.com/Silic0nS0ldier/vscode-git-monolithic-extension/actions/runs/20874315621/job/59981273756#step:4:29 (the same failure in automated checks).

This same error is also coming up in the update PR for a private project.

@Silic0nS0ldier Silic0nS0ldier mentioned this pull request Jan 10, 2026
Merged
1 task
@alexeagle
Copy link
Copy Markdown
Collaborator

alexeagle commented Jan 10, 2026

@jbedard I had to revert here too aspect-build/rules_lint@da12196

@jbedard
Copy link
Copy Markdown
Collaborator Author

jbedard commented Jan 10, 2026

@alexeagle did you determine what is actually going on?

@jbedard
Copy link
Copy Markdown
Collaborator Author

jbedard commented Jan 12, 2026

See #1233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbedard @Silic0nS0ldier @alexeagle