Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/bazel-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.1.0
Choose a base ref
...
head repository: bazel-contrib/bazel-lib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.1
Choose a head ref
  • 3 commits
  • 12 files changed
  • 3 contributors

Commits on Dec 26, 2025

  1. Configuration menu
    Copy the full SHA
    3da7568 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2026

  1. fix: Using "current_working_dir" instead of "runfiles_dir" at write_s…

    …ource_files (#1232)
    
    This is a fix for: write_source_files: wrong runfiles_dir assignment
    with runfiles enabled for windows #1223
    
    The working dir differs when runfiles are enabled. On windows the
    variables are not case sensitive, so that an assignment to
    "runfiles_dir" overwrites the "RUNFILES_DIR" env var (which is wrong,
    when runfiles are enabled).
    tokup authored Jan 11, 2026
    Configuration menu
    Copy the full SHA
    8aff7dc View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2026

  1. fix: Windows batch file line endings to avoid cmd parsing bug (#1222)

    Windows cmd has a known bug where GOTO/CALL to labels fails when batch
    files use LF-only line endings and the label crosses a 512-byte boundary
    during parsing. This causes "cannot find batch label" errors like, for
    `diff_test`:
    ```
    The system cannot find the batch label specified - compare_files
    ```
    
    References:
    - https://www.dostips.com/forum/viewtopic.php?t=8988
    - rocq-prover/rocq#8610
    
    This fix ensures all generated .bat files use CRLF line endings by
    converting templates and using \r\n in string replacements throughout:
    - diff_test: template and substitutions,
    - write_source_file: batch updater scripts,
    - windows_utils: native launcher scripts.
    
    To verify these changes work correctly across platforms, we add a Go
    binary (`check_newlines`) that validates line endings:
    - on Windows: verifies scripts have proper CRLF line endings,
    - otherwise: verifies \n to \r\n replacements don't affect POSIX
    scripts.
    
    Note: we initially considered `sh_test` with PowerShell/batch wrappers,
    but encountered issues with interpreter dependencies, script
    portability, and symlink handling across platforms.
    A single Go binary invoked via `native_test` proved more reliable and
    maintainable, working consistently across all platforms (no new external
    dependencies either).
    rdesgroppes authored Jan 13, 2026
    Configuration menu
    Copy the full SHA
    8a8fcd6 View commit details
    Browse the repository at this point in the history
Loading