squash! make varlink optional for podman#1
Merged
baude merged 1 commit intobaude:varlink_optionalfrom Jun 22, 2018
Merged
Conversation
The API.md and cmd/podman/varlink/ioprojectatomicpodman.go targets will continue to work regardless of the presence (or not) of 'varlink' is in BUILDTAGS. However, cmd/podman/varlink/ioprojectatomicpodman.go is now only required by the podman target when BUILDTAGS contains 'varlink'. API.md had also been an podman dependency since 5b2627d (Makefile: Drop find-godeps.sh for podman target, 2018-05-15, containers#776) when I expanded varlink_api_generate. It had been an indirect podman dependency (via varlink_api_generate) since 2526355 (Generate varlink API documentation automatically, 2018-05-07, containers#734). But the podman executable obviously doesn't depend on the Markdown file, so I'm removing that dependency here.
26aa584 to
355a1ca
Compare
baude
pushed a commit
that referenced
this pull request
Jul 10, 2019
It's desirable to make archives available of builds containing actual
tested content. While not official distro-releases, these will enable
third-party testing, experimentation, and development for both branches
(e.g. "master") and pull requests (e.g. "pr3106").
* Add a Makefile targets for archiving both regular podman binaries
and the remote-client. Encode release metadata within these
archives so that their exact source can be identified.
* Fix bug with cross-compiling remote clients for the Windows and Darwin
platforms.
* Add unit-testing of cross-compiles for Windows and Darwin platforms.
* A few small CI-script typo-fixes
* Add a script which operates in two modes:
1. Call Makefile targets which produce release archives.
Upload the archive to Cirrus-CI's built-in caching system
using reproducible cache keys.
2. Utilize reproduced cache keys to attempt download of cache
from each tasks. When successful, parse the file's
release metadata, using it to name the archive file. Upload
all recovered archives to a publicly accessible storage bucket
for future reference.
* Update the main testing task to call the script in mode #1 for
all primary platforms.
* Add a new `$SPECIALMODE` task to call the script in mode #1 for
Windows and Darwin targets.
* Add a new 'release' task to the CI system, dependent upon all other
tasks. This new tasks executes the script in mode #2.
* Update CI documentation
Signed-off-by: Chris Evich <[email protected]>
baude
pushed a commit
that referenced
this pull request
Jun 16, 2020
baude
pushed a commit
that referenced
this pull request
Apr 30, 2021
Our current #1 flake; this is a simple one: we can't run 'logs' on a container run with '-d --rm'. Signed-off-by: Ed Santiago <[email protected]>
baude
pushed a commit
that referenced
this pull request
Sep 14, 2021
go test -v -p 1 -tags apparmor,ostree,seccomp,selinux,systemd github.com/containers/podman/v2/test/testvol results in the following error: > test/testvol/main.go:227:10: Errorf format %s reads arg #1, but call has 0 args > test/testvol/main.go:233:10: Errorf format %s reads arg #1, but call has 0 args This patch passes req.Name as an argument to the Errorf() call Signed-off-by: Raoul Bhatia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
API.mdandcmd/podman/varlink/ioprojectatomicpodman.gotargets will continue to work regardless of the presence (or not) ofvarlinkis inBUILDTAGS. However,cmd/podman/varlink/ioprojectatomicpodman.gois now only required by thepodmantarget whenBUILDTAGScontainsvarlink.API.mdhad also been an podman dependency since 5b2627d (containers#776) when I expandedvarlink_api_generate. It had been an indirect podman dependency (viavarlink_api_generate) since 2526355 (containers#734). But thepodmanexecutable obviously doesn't depend on the Markdown file, so I'm removing that dependency here.