Skip to content

squash! make varlink optional for podman#1

Merged
baude merged 1 commit intobaude:varlink_optionalfrom
wking:varlink-makefile-cleanup
Jun 22, 2018
Merged

squash! make varlink optional for podman#1
baude merged 1 commit intobaude:varlink_optionalfrom
wking:varlink-makefile-cleanup

Conversation

@wking
Copy link

@wking wking commented Jun 22, 2018

The API.md and cmd/podman/varlink/ioprojectatomicpodman.go targets will continue to work regardless of the presence (or not) of varlink is in BUILDTAGS. However, cmd/podman/varlink/ioprojectatomicpodman.go is now only required by the podman target when BUILDTAGS contains varlink.

API.md had also been an podman dependency since 5b2627d (containers#776) when I expanded varlink_api_generate. It had been an indirect podman dependency (via varlink_api_generate) since 2526355 (containers#734). But the podman executable obviously doesn't depend on the Markdown file, so I'm removing that dependency here.

The API.md and cmd/podman/varlink/ioprojectatomicpodman.go targets
will continue to work regardless of the presence (or not) of 'varlink'
is in BUILDTAGS.  However, cmd/podman/varlink/ioprojectatomicpodman.go
is now only required by the podman target when BUILDTAGS contains
'varlink'.

API.md had also been an podman dependency since 5b2627d (Makefile:
Drop find-godeps.sh for podman target, 2018-05-15, containers#776) when I
expanded varlink_api_generate.  It had been an indirect podman
dependency (via varlink_api_generate) since 2526355 (Generate varlink
API documentation automatically, 2018-05-07, containers#734).  But the podman
executable obviously doesn't depend on the Markdown file, so I'm
removing that dependency here.
@wking wking force-pushed the varlink-makefile-cleanup branch from 26aa584 to 355a1ca Compare June 22, 2018 19:38
@baude baude merged commit 355a1ca into baude:varlink_optional Jun 22, 2018
@wking wking deleted the varlink-makefile-cleanup branch June 28, 2018 04:30
baude pushed a commit that referenced this pull request Jul 10, 2019
It's desirable to make archives available of builds containing actual
tested content.  While not official distro-releases, these will enable
third-party testing, experimentation, and development for both branches
(e.g. "master") and pull requests (e.g. "pr3106").

* Add a Makefile targets for archiving both regular podman binaries
  and the remote-client.  Encode release metadata within these
  archives so that their exact source can be identified.

* Fix bug with cross-compiling remote clients for the Windows and Darwin
  platforms.

* Add unit-testing of cross-compiles for Windows and Darwin platforms.

* A few small CI-script typo-fixes

* Add a script which operates in two modes:

  1. Call Makefile targets which produce release archives.
     Upload the archive to Cirrus-CI's built-in caching system
     using reproducible cache keys.

  2. Utilize reproduced cache keys to attempt download of cache
     from each tasks.  When successful, parse the file's
     release metadata, using it to name the archive file.  Upload
     all recovered archives to a publicly accessible storage bucket
     for future reference.

* Update the main testing task to call the script in mode #1 for
  all primary platforms.

* Add a new `$SPECIALMODE` task to call the script in mode #1 for
  Windows and Darwin targets.

* Add a new 'release' task to the CI system, dependent upon all other
  tasks.  This new tasks executes the script in mode #2.

* Update CI documentation

Signed-off-by: Chris Evich <[email protected]>
baude pushed a commit that referenced this pull request Jun 16, 2020
baude pushed a commit that referenced this pull request Apr 30, 2021
Our current #1 flake; this is a simple one: we can't run 'logs'
on a container run with '-d --rm'.

Signed-off-by: Ed Santiago <[email protected]>
baude pushed a commit that referenced this pull request Sep 14, 2021
go test -v -p 1 -tags apparmor,ostree,seccomp,selinux,systemd github.com/containers/podman/v2/test/testvol
results in the following error:

> test/testvol/main.go:227:10: Errorf format %s reads arg #1, but call has 0 args
> test/testvol/main.go:233:10: Errorf format %s reads arg #1, but call has 0 args

This patch passes req.Name as an argument to the Errorf() call

Signed-off-by: Raoul Bhatia <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants