Skip to content

Install bats binary with npm install#430

Merged
martin-schulze-vireso merged 1 commit intobats-core:masterfrom
felipecrs:patch-1
Apr 24, 2021
Merged

Install bats binary with npm install#430
martin-schulze-vireso merged 1 commit intobats-core:masterfrom
felipecrs:patch-1

Conversation

@felipecrs
Copy link
Contributor

So npm install --global bats && bats --version is supposed to work.

So npm install --global bats && bats --version is supposed to work.
@martin-schulze-vireso martin-schulze-vireso merged commit abd790a into bats-core:master Apr 24, 2021
@jasonkarns
Copy link
Member

What changed with this? Per the docs, "directories": { "bin": "bin", is supposed to create the bin symlink already.

@jasonkarns
Copy link
Member

Actually, this needs reverted. Not only is bin not supposed to be necessary, specifying both is actually an error:

If you specify a bin directory in directories.bin, all the files in that folder will be added.

Because of the way the bin directive works, specifying both a bin path and setting directories.bin is an error. If you want to specify individual files, use bin, and for all the files in an existing bin directory, use directories.bin.

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#directoriesbin

@felipecrs
Copy link
Contributor Author

I'm really sorry about it. So it turns out that it's an issue in Volta.

volta-cli/volta#978

@felipecrs felipecrs deleted the patch-1 branch April 24, 2021 16:41
@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Apr 24, 2021

@jasonkarns I'll take that as a lesson to let my fingers off node related PRs. I read the documentation about bin and it sounded fitting. No mention about directories.bin there.

Could you do the revert @jasonkarns? I am not sure when I will find the time.

@felipecrs
Copy link
Contributor Author

martin-schulze-vireso added a commit that referenced this pull request Apr 25, 2021
Revert "Merge pull request #430 from felipecrs/patch-1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants