Develop 3.0 292 solrupdate#767
Merged
Merged
Conversation
7.4 came ⇒ 7.3.1 disappeared everywhere!
It doesn't check user-provided path in any way. This allows overriding any file on the system with riak permissions.
Security fixes
1. if HTTP API is exposed:
- read any file on the system — via /search/extract, the error message leaks
file content;
- send HTTP «GET /» request to any host — by PUT/POSTing text/xml document,
or via /search/extract. This is also likely riak DoS if the host is
attacker-controlled.
2. if PB API is exposed:
- send HTTP «GET /» request to any host — by PUT/POST, see above.
3. if HTTP API is exposed:
- override (with garbage) any file on the system with riak permissions.
Update ibrowse
Outstanding ssue with behaviours not being recognised
Also don't xref for locals_not_used as there are debug statements that are compiled to not warn in dialyzer - but will be flagged by xref
…-3.0-292-solrupdate
Changes required to support building of riak_test cases in OTP 20 - 22.
Align with other repos
Actually build solr again!
Where bench is expecting to find it
eqc tests will now run (and pass) using `./rebar3 as eqc do eunit`
Author
|
There is also an issue with needing to include basho_bench as a dep in order to get riak_tests to run (many yokozuna riak_tests require basho_bench). |
martincox
approved these changes
Apr 30, 2020
martincox
left a comment
martincox
left a comment
There was a problem hiding this comment.
As far as the Erlang stuff goes, which looks to be the usual OTP20+ / relx fixups, looks good to me. Can't really comment on the Java / Solr side of things, but happy for it to be merged.
martinsumner
marked this pull request as ready for review
June 16, 2020 09:25
martinsumner
added a commit
to basho/riak
that referenced
this pull request
Jul 9, 2020
Change commented yokozuna branch, as this basho/yokozuna#767 is now merged into develop-3.0, and new updates are being PR'd into 3.0 (e.g. basho/yokozuna#768)
martincox
pushed a commit
to bet365/riak
that referenced
this pull request
Jul 9, 2020
Change commented yokozuna branch, as this basho/yokozuna#767 is now merged into develop-3.0, and new updates are being PR'd into 3.0 (e.g. basho/yokozuna#768)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the uplift of the solr version, and some changes to allow riak_test to run on OTP 20+.
However, there still are riak_test failures. The failures appear to fall into three broad categories:
I think this should still be merged in, then we need to make the decision whether to: