Develop 2.2.5 fix logging test and product checks#1304
Closed
ghost wants to merge 2 commits into
Closed
Conversation
ghost
mentioned this pull request
Merged
Author
|
Closing as #1303 taken lager matcher |
ghost
closed this
ghost
deleted the
develop-2.2.5-fix-logging-test-and-product-checks
branch
March 26, 2018 13:01
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to @russelldb #1303 but just matches on the content - I suspect the '\r\n' could be something OSX related - although searching docs, issues, code in lager didn't find anything. I've also tested this branch on Linux (Centos 7) and it passes there too.