Skip to content

Sticking plaster fix for basho/riak_repl#772#779

Merged
russelldb merged 3 commits into
develop-2.2from
bug/rdb/gh772
Mar 22, 2018
Merged

Sticking plaster fix for basho/riak_repl#772#779
russelldb merged 3 commits into
develop-2.2from
bug/rdb/gh772

Conversation

@russelldb

Copy link
Copy Markdown
Contributor

Changes to defaults, tests for same. See #772 for background

No riak_test, but unit tests. Hard to give you a before an after to run, therefore.

See riak_repl#772 for details. Also adds an enqueued timestamp to the
purgatory queue (??you mean retry_queue right??) so that there can be
some waiting between attempts to fullsync a locked/building remote partition.
After failing to craft a riak_test in a timely manner, elected for eunit
tests.  A little ugly thanks to the way side-effects are mixed into the
coordinator code (especially the sending/receiving of whereis messages)

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM - tests pass

@russelldb
russelldb merged commit f6e650e into develop-2.2 Mar 22, 2018
@russelldb
russelldb deleted the bug/rdb/gh772 branch March 22, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant