Fix bug when passing utc timestamps into httpd_util:rfc1123/1.#776
Merged
Conversation
…unction expects a localtime and throws an exception otherwise. This is evident when the clocks go forward for DST and a time falling in the skipped hour is passed into the function. The fact that an exception is thrown is down to a bug in OTP which was patched in 20.1.
Contributor
Author
|
@russelldb @Vagabond @binarytemple-external needs a quick review / merge if anyone can spare a couple of mins? |
|
I don't have review rights, but I'll give it a +1 I guess from your commit message we can dump it later when everything is running on 20.2+ but that's the future, better to think in the present. |
|
fixes #775 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function expects a localtime and throws an exception otherwise. This is evident when the clocks go forward for DST and a time falling in the skipped hour is passed into the function.
The fact that an exception is thrown is down to a bug in OTP which was patched in 20.1.