I think these changes look good, but I do not see a clear way to test. Is it correct that this pr and this one for kv are just to lay the foundation and the riak-erlang-client will be updated later to add direct support for 2I? It looks like right now the riak-erlang-client is still using mapreduce for 2I even in the sdc-pbc-extract branch.

@kellymclaughlin That is correct. Unfortunately I didn't have the time to do the erlang client yet, I'll try to get up a branch in the next few days. However since it is not a dependency of the server code now, it can be done in a different stream.

I did test it with the Ruby client by quickly hacking in the messages and response processing. https://gist.github.com/f5d4599cff9e2f9f9c91 You can apply the diff in that directly on top of master.

Ok thanks for the explanation. That's what I thought, but just wanted to make sure I wasn't missing a pr somewhere.

On May 30, 2012, at 5:22 AM, Sean Cribbs wrote:

@kellymclaughlin That is correct. Unfortunately I didn't have the time to do the erlang client yet, I'll try to get up a branch in the next few days. However since it is not a dependency of the server code now, it can be done in a different stream.

I did test it with the Ruby client by quickly hacking in the messages and response processing. https://gist.github.com/f5d4599cff9e2f9f9c91 You can apply the diff in that directly on top of master.

---

Reply to this email directly or view it on GitHub:
#1 (comment)

+1 to merge