Conversation
ghost
assigned
Contributor
There was a problem hiding this comment.
I know this is not something you did directly, but the function name in the spec doesn't match the actual function name.
Contributor
|
Diff between this branch and |
Contributor
There was a problem hiding this comment.
s/riak_kv_pb_object/riak_kv_pb_index
Contributor
Author
|
@kellymclaughlin Fixed typos and also followed @rzezeski's suggestion about using |
Contributor
|
HTTP and mapreduce 2I queries still work for me. The changes from |
Contributor
|
+1 to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a series of pull-requests that adds native 2I queries to the Protocol Buffers interface. In my unscientific tests, the native query shows a 50-80% improvement over the emulation via MapReduce. (See https://gist.github.com/f5d4599cff9e2f9f9c91)
Related: basho/riak_pb#1
NOTE: This requires the PBC refactoring (#321) to be present first.