Mas i1850 handoffdelete#1851
Merged
Merged
Conversation
stephenwood24-nhs
approved these changes
Feb 8, 2023
martinsumner
added a commit
that referenced
this pull request
Feb 13, 2023
* Handoff deletes * Make delete handoff configurable
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently delete requests do not handoff. This means that deletes which happen during handoffs do not get reaped (i.e. when delete_mode is not keep).
The option to handoff deletes is added as a non-default configuration. It should probably be default behaviour, however, it is not clear if not making this default behaviour was at some stage a deliberate decision.
Test - basho/riak_test#1371