add missing function clause repair_keys_range in convert_fold#1839
Merged
Conversation
…reak aae_fold for that case
Contributor
|
As I understand it convert_fold is only used normally via Lines 905 to 911 in 9ca7184 The Do you want to make this quick fix as part of this PR, and pass Q0 through to the query? I have a riak_test ready. This test extends If you update the PR with the second fix, the test should pass |
martinsumner
self-requested a review
December 1, 2022 13:39
martinsumner
approved these changes
Dec 1, 2022
martinsumner
pushed a commit
that referenced
this pull request
Dec 19, 2022
* add missing function clause repair_keys_range in convert_fold, to unbreak aae_fold for that case * thread converted aae_fold query in riak_client, to complete prev commit
martinsumner
added a commit
that referenced
this pull request
Dec 19, 2022
* Do not crash when object's contents is an empty list (#1837) * Add test to illustrate issue * Do not crash when object's contents is an empty list * add missing function clause repair_keys_range in convert_fold (#1839) * add missing function clause repair_keys_range in convert_fold, to unbreak aae_fold for that case * thread converted aae_fold query in riak_client, to complete prev commit * Change the default PR value from 0 to default (#1836) This means that get requests will use bucket-type level Primary Read settings Co-authored-by: Peter Tihanyi <[email protected]> * Mas i1121 reip3 (#1838) * Add reip/3 To allow for reip without loading the riak_core application * Use alternate name * Update riak_kv_console.erl * Update riak_kv_console.erl * reip_manual inputs are atoms * Add warning to update riak.conf file after reip * Make clear where attention is required And return 'ok' to make clear the op was successful * Update rebar.config * Update log (#1840) Make situation clearer in log Rather than change behaviour, just make it clear that the warning can be ignored when shutting down. This should avoid unnecessary concern. * Update Readme, remove mercurial refs Co-authored-by: Enrique Fernández <[email protected]> Co-authored-by: Andrei Zavada <[email protected]> Co-authored-by: Peter Tihanyi <[email protected]> Co-authored-by: Peter Tihanyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to unbreak
aae_foldforrepair_keys_range.In collaboration with @pjaclark.