Set Index hashtree sync_stop timeout to infinity#1803
Merged
Conversation
Contributor
|
I think there are plenty of situations where 5s could be too short, so I agree about changing this. However, do we want to allow this to try forever, especially as it can recover from the crash? My gut feeling is to use 60s not infinity. That is just an immediate reaction though, happy to discuss. I will review that area of the code in more detail later this week, but I will make sure whatever we agree to change goes into the 3.0.9 release which should be out in the next 2 weeks. |
Contributor
Author
|
Agree, 60 sec could be enough (or at least helps a lot) and we won't run the risk what if it hangs somehow. Thanks! |
martinsumner
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stopping a riak node,
riak_kv_vnodeterminates andriak_kv_index_hashtree:sync_stop/1called.This may end up in crash if it could not finish in 5 sec:
CRASH REPORT Process <0.1193.0> with 1 neighbours exited with reason: {timeout,{gen_server,call,[<0.1248.0>,stop]}} in gen_fsm:terminate/7 line 600I think this could created a situation where a normal riak stop can cause this error:
CRASH REPORT Process <0.3158.0> with 0 neighbours exited with reason: no match of right hand value {error,{db_open,"Corruption: truncated record at end of file"}} in hashtree:new_segment_store/2 line 728 in gen_server:init_it/6 line 328