Fix equal/2 bug around unordered dict usage#135
Merged
Conversation
When `riak_dt_map` moved from `orddict` to `dict` the `equal/2` function
was not updated to reflect that the `deferred` operations list was now
an unordered `dict`, meaning two equal maps could report as unequal just
because of the order of operations in the deferred dict. The bug was
found by the added counter-example
`test/non-commute-counter-example.eqc`.
I also added a function `map_eqc:check/1` so that any counter-example
file can be easily run from the shell.
Run `./rebar eunit skip_deps=true deps_dir=../ compile_only=true` and
then `erl -pa .eunit/` and
`map_eqc:check("test/non-commute-counter-example.eqc")` before and after
the change to `riak_dt_map.erl` to verify the fix.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
riak_dt_mapmoved fromorddicttodicttheequal/2functionwas not updated to reflect that the
deferredoperations list was nowan unordered
dict, meaning two equal maps could report as unequal justbecause of the order of operations in the deferred dict. The bug was
found by the added counter-example
test/non-commute-counter-example.eqc.I also added a function
map_eqc:check/1so that any counter-examplefile can be easily run from the shell.
Run
./rebar eunit skip_deps=true deps_dir=../ compile_only=trueandthen
erl -pa .eunit/andmap_eqc:check("test/non-commute-counter-example.eqc")before and afterthe change to
riak_dt_map.erlto verify the fix.