Add a soft-limit check to vnode proxy#921
Closed
russelldb wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See riak#1661 for initial issue/discussion.
This PR supports basho/riak_kv#1670
Adds a message (call and cast) for getting the estimated length of the mailbox queue from the vnode proxy. The returns of
soft-limitindicates that the estimate of the vnode queue length is greater or equal to double the check interval. The return includes the mailbox queue estimated length and the check interval (i.e. soft-limit / 2) so that the caller can make their own decisions about the load state of the vnode.NOTE: in our testing we lowered the check interval down to
50as even a small increase in queue size can lead to high outlying latency increases for coordinated operations.