Check for old configs#1
Merged
Merged
Conversation
Since users will more than likely not immediately update their app configs before restarting Riak after an upgrade then Riak API needs to check for the old configs. If the old config is found then that value will be used and a warning will be logged.
ghost
assigned
|
@rzezeski @kellymclaughlin The other alternative is to simply not start the PB listener when it is not configured, which is what |
Contributor
Author
|
Yea, that makes sense as some users may not want the PB interface enabled. |
|
👍 to merge if you find my modifications sufficient |
Contributor
Author
|
This application is started before lager and therefore the log msgs don't show up but #2 is going to address that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since users will more than likely not immediately update their app
configs before restarting Riak after an upgrade then Riak API needs to
check for the old configs. If the old config is found then that value
will be used and a warning will be logged.
This relies on basho/riak_core#182