These changes look good to me, +1.

I wonder about the app.config changes. From my understanding when a user upgrades the pkg installers will keep the old app.config. This means that riak_api will revert to defaults if user doesn't migrate PB config from riak_core to riak_api. This poses a problem if said user has modified their PB settings (especially IP/Port).

The other problem is that if they simply use the old version of the config then riak fails to start at all with ugly errors. I made a comment about more helpful error messages in that regard on the riak_kv pr. In the interest of backward compatibility maybe riak_api should also check for the existence of the properties in the riak_core section and use those in the absence of riak_api properties in addition to some friendly lager reminders to upgrade the code. Then a couple of versions from now we can take out the riak_core check.

I agree. I'm going to fix riak_api to do just that. I feel in the future we'll need a better story than "make sure you go into all your app configs and change this stuff or things will break in the future."

Hopefully this fixes the upgrade path, need to test still.

basho/riak_api#1

The recent riak_api additions fix the upgrade path and allow PB to function with old configs.

+1 to merge.