Skip to content

Unbreak 32-bit build#242

Merged
martinsumner merged 7 commits into
basho:develop-3.0from
TI-Tokyo:develop-3.0
Jun 21, 2022
Merged

Unbreak 32-bit build#242
martinsumner merged 7 commits into
basho:develop-3.0from
TI-Tokyo:develop-3.0

Conversation

@hmmr

@hmmr hmmr commented May 20, 2022

Copy link
Copy Markdown

This PR:

  • replaces deprecated auto_ptr with unique_ptr;
  • drops some dead code (port/port_chromium.h is not present in the project and LEVELDB_PLATFORM_CHROMIUM is never defined);
  • enables building on 32-bit arches, by dropping workarounds in various add_and_fetch and dec_and_fetch and directly falling through to gcc built-ins. Specifically, x86, where it also passes the tests.

Eleveldb tests are passing.

@hmmr hmmr mentioned this pull request May 20, 2022
Merged
@martinsumner

martinsumner commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Was the change to table_test.cc due to an intermittent test failure?

@hmmr

hmmr commented Jun 8, 2022

Copy link
Copy Markdown
Author

It wasn't even intermittent (it was reliably failing all the times I ran the tests). #232 suggests it was failing all along. I was unable to dig deeper and find the root cause of it failing; I can only confirm that the upgrade of snappy didn't make it worse.

@martinsumner
martinsumner merged commit 6fb8242 into basho:develop-3.0 Jun 21, 2022
@hmmr
hmmr deleted the develop-3.0 branch June 21, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@martinsumner martinsumner martinsumner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmmr @martinsumner