Add a 10% fuzz factor to the resident memory calc (intermittent test failure "fixes")#243
Merged
Conversation
On some platforms (or on ubuntu-16.04 server in my lab at least) this test fails going a little over the expected max resident memory. However, even with loads more loops, a 10% fuzz factor is enough for it to pass. If there is a leak, it is a marginal one that never grows above 10% of the best case, which is good enough, since this code has been in the wild long enough.
Left in by mistake when trouble shooting failure
Contributor
|
+1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms (or on ubuntu-16.04 server in my lab at least) this
test fails going a little over the expected max resident
memory. However, even with loads more loops, a 10% fuzz factor is enough
for it to pass. If there is a leak, it is a marginal one that never
grows above 10% of the best case, which is good enough, since this code
has been in the wild long enough.