Non-deterministic test needs a little ?SOMETIMES#13
Merged
Conversation
prop_quantile/0 is by it's nature non-deterministic, and the comments/notes make it clear. Rather than tolerate it breaking the build periodically, this commit changes the property by using eqc's `?SOMETIMES` macro. If a test fails 3 times in a row then we assume that it is a deterministic failure, a bug. Otherwise, assume it is the noted "loosy goosy" nature of the comparison and pass the property. NOTE: still think we should find and fit the error bounds.
|
+1. +10 for loosy goosy 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prop_quantile/0 is by it's nature non-deterministic, and the
comments/notes make it clear. Rather than tolerate it breaking the build
periodically, this commit changes the property by using eqc's
?SOMETIMESmacro. If a test fails 3 times in a row then we assume thatit is a deterministic failure, a bug. Otherwise, assume it is the noted
"loosy goosy" nature of the comparison and pass the property. NOTE:
still think we should find and fit the error bounds.