Improve defense mechanisms against tampering protection controls#20
Merged
Conversation
The new system is based on `Class.freeze`, which cover way more cases than the old system based on the hook `.method_added`.
jorgemanrubia
force-pushed
the
improved-protection
branch
from
August 28, 2021 19:08
0b31443 to
ef6171f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes several improvements to prevent circumventing protection controls:
.freezeand it also prevents changing class-level state. A big flaw in the previous approach, based on themethod_addedhook, is that, while it raised an error, it wouldn't prevent the command from executing (it was evaluated after).instance_variableset on core classes.ActiveRecordclasses for monkey patching them.Console1984,ActiveRecord).It also includes a new system for testing tampering cases that should be detected: just place the snippet
test/tampering_cases. A test will run for each file and it will fail if it's not detected.Fix #19