Skip to content

Address PR #166 review feedback#174

Merged
jeremy merged 2 commits intomainfrom
address-pr-166-reviews
Mar 1, 2026
Merged

Address PR #166 review feedback#174
jeremy merged 2 commits intomainfrom
address-pr-166-reviews

Conversation

@jeremy
Copy link
Member

@jeremy jeremy commented Mar 1, 2026

Summary

  • Fix CI labeler config to drop area/ prefix from labels
  • Harden release workflow: add worktree trap cleanup, jq guard, stderr capture in surface check

Test plan

  • CI passes on this branch

- Rename labeler keys to area/* namespace (area/commands, area/tui, etc.)
  and add area/docs, area/deps categories
- Capture stderr from --help --agent instead of suppressing with 2>/dev/null
- Write changelog diff to file instead of shell variable to avoid size limits
- Add worktree cleanup trap for baseline surface check on failure
- Add jq preflight check to make check-surface
Keep the plain names — no namespace needed for this repo.
Copilot AI review requested due to automatic review settings March 1, 2026 02:03
@github-actions github-actions bot added ci CI/CD workflows bug Something isn't working labels Mar 1, 2026
@jeremy jeremy merged commit 7796950 into main Mar 1, 2026
46 checks passed
@jeremy jeremy deleted the address-pr-166-reviews branch March 1, 2026 02:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens CI/release reliability around CLI surface checks and release changelog context generation, and updates label automation.

Changes:

  • Improve CLI surface snapshot error reporting by capturing and printing stderr on failure.
  • Add a jq presence guard to make check-surface, and harden release workflow worktree cleanup via trap.
  • Extend PR label automation with docs and deps path-based labels.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
scripts/check-cli-surface.sh Capture stderr from --help --agent calls to improve debuggability on failures.
Makefile Add an explicit jq preflight check before generating CLI surface snapshots.
.github/workflows/release.yml Add worktree cleanup trap and avoid storing large diffs in shell variables by writing to a file.
.github/labeler.yml Add docs and deps label rules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci CI/CD workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants