Conversation
- Rename labeler keys to area/* namespace (area/commands, area/tui, etc.) and add area/docs, area/deps categories - Capture stderr from --help --agent instead of suppressing with 2>/dev/null - Write changelog diff to file instead of shell variable to avoid size limits - Add worktree cleanup trap for baseline surface check on failure - Add jq preflight check to make check-surface
There was a problem hiding this comment.
Pull request overview
This PR addresses unresolved review feedback from #166, which introduced CI/CD tooling including path-based auto-labeling, CLI surface checks, and an AI changelog generator. The changes are all small, targeted improvements to the previously introduced tooling.
Changes:
- Rename all labeler keys to the
area/*namespace and add two new labels (area/docs,area/deps) - Capture stderr from
--help --agentbinary invocations in the surface check script (instead of suppressing it), and write changelog diff to a temp file instead of a shell variable to avoid size limits - Add a worktree cleanup
trapto the release workflow for reliability on failure, and ajqpreflight check tomake check-surface
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/labeler.yml |
Renames 9 bare labels to area/* namespace and adds area/docs and area/deps entries |
scripts/check-cli-surface.sh |
Captures stderr from binary invocations to a temp file and surfaces it on failure, instead of silently discarding it |
Makefile |
Adds a jq preflight check with install guidance before invoking the surface check script |
.github/workflows/release.yml |
Adds a worktree cleanup trap for the baseline surface check and writes changelog diff to a file instead of a shell variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Keep the plain names — no namespace needed for this repo.
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
area/*namespace and addarea/docs,area/deps--help --agentinvocations instead of suppressingmake check-surfaceAddresses unresolved review threads from #166.
Test plan
make check-surfaceworks with and without jq