Fix Docker latest tag gating and PGO failure visibility#157
Merged
Conversation
- Only tag Docker images as `latest` for non-prerelease versions (prevents -rc/-beta tags from stealing latest) - Surface PGO benchmark failures with per-package warnings and a summary count instead of silently swallowing them - Fix runbook wording: RELEASE_CLIENT_ID is a repo variable, not a secret
Drop redundant version heading (already in release title), use fenced code block for install instructions, add auth login step.
Omarchy-first, macOS second in release notes header template.
jeremy
force-pushed
the
first-release
branch
from
52b81b6 to
575ea8c
Compare
There was a problem hiding this comment.
Pull request overview
This PR applies post–v0.1.0 release-process fixes to prevent prereleases from overwriting the Docker latest tag and to surface when PGO benchmark collection fails (so profile quality degradation isn’t silent).
Changes:
- Gate the Docker
latesttag so it’s only produced for non-prerelease versions. - Replace
|| truein the PGO benchmark loop with per-package failure tracking and a summary warning. - Add a first-release plan/runbook doc under
.claude/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.goreleaser.yaml |
Makes latest tagging conditional on non-prerelease versions. |
.github/workflows/release.yml |
Improves PGO benchmark failure visibility and keeps the workflow moving with warnings. |
.claude/first-release-plan.md |
Adds release planning/runbook documentation for the initial release process. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-release fixes from v0.1.0 review findings:
latesttag gating: Only tag Docker images aslatestfor non-prerelease versions. Previously, a-rc1or-betatag would steallatestfrom the last stable release. Uses goreleaser's{{ if not .Prerelease }}latest{{ end }}template — empty tags are silently ignored.|| truewith per-package failure tracking and a summary warning. Benchmark failures no longer silently degrade profile quality.RELEASE_CLIENT_IDis a repo variable (vars.*), not a secret.Test plan
goreleaser checkpassesv0.2.0-rc1) should produce versioned Docker tag only, nolatestlatestDocker tags