V1 ship polish: layout, visual consistency, focus lifecycle, chrome#156
Merged
V1 ship polish: layout, visual consistency, focus lifecycle, chrome#156
Conversation
There was a problem hiding this comment.
Pull request overview
This is a final polish pass before V1 ship addressing layout consistency, visual polish, focus lifecycle improvements, cross-account boost routing, and chrome discoverability. The PR builds on #155 by ensuring project-scoped views (Todos, Messages, Cards, Detail) include AccountID in BoostTarget for correct cross-account boost routing, matching the pattern already established in Hey/Assignments/Pulse.
Changes:
- Toast overlay now replaces penultimate line instead of pushing layout, preventing content reflow
- All ellipsis changed from ASCII
...to Unicode…for visual consistency across loading states and truncation - Search refocuses text input on FocusMsg, Detail does silent refresh when data exists
- QuickJump categories capitalized, Detail FullHelp exposes scroll bindings, date placeholders use relative dates
- Right-panel spinners now fill their panel with width/height constraints
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tui/workspace/workspace.go | Toast overlay implementation, createBoostFunc spy injection, BoostPicker relayout, CreateBoost cross-account routing |
| internal/tui/workspace/workspace_test.go | BoostPicker initialization in test helpers, cross-account boost tests, toast layout stability test |
| internal/tui/workspace/msg.go | Added AccountID to BoostTarget struct |
| internal/tui/workspace/data/hub.go | CreateBoost signature updated for cross-account routing with ClientFor lookup |
| internal/tui/workspace/data/hub_global.go | Ellipsis changed to Unicode in PingRooms and timeline excerpt truncation |
| internal/tui/workspace/views/*.go | AccountID added to BoostTarget in todos/messages/cards/detail/hey/pulse/assignments, ellipsis updates, loading spinner polish |
| internal/tui/workspace/views/search.go | FocusMsg refocuses text input on back-nav |
| internal/tui/workspace/views/detail.go | Silent refresh on FocusMsg when data exists, FullHelp scroll bindings, date placeholders, ellipsis updates |
| internal/tui/workspace/widget/*.go | Truncate function updated to use Unicode ellipsis with rune-safe truncation |
| internal/tui/workspace/chrome/*.go | QuickJump categoryLabel capitalization, account switcher humanized error, metrics panel ellipsis |
| internal/tui/format/recording.go | Ellipsis changed to Unicode in truncate function |
| internal/tui/*.go | Loading messages updated to Unicode ellipsis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Toast was appended as a layout section between content and status bar, causing the main content area to shrink by one row for the 3s duration. Now overlays the penultimate line (above status bar) so content height stays constant—no reflow on show/hide.
Todos, Cards, Messages, and Detail views built BoostTarget without AccountID, causing CreateBoost to fall through to the wrong account in multi-account setups. Now set from session scope, matching the pattern already used by Hey, Assignments, and Pulse.
- Normalize "..." to "…" across all loading messages and truncation - Right-panel spinners in Todos/Messages/Checkins fill their panel with Width/Height instead of floating in the corner - Checkins truncateContent: rune-safe truncation for multibyte chars - Kanban: "No cards" instead of "(empty)", deferred shows hint text - MyStuff: thin rule separator between sections - Home: label truncation adds ellipsis - Widget Truncate threshold adjusted for single-char "…"
…esize - Search: handle FocusMsg to refocus text input after back-navigation - Detail: FocusMsg with existing data does silent refresh (no spinner flash) — only shows loading indicator when data is nil - BoostPicker: include in relayout() so terminal resize while open doesn't use stale dimensions
…ders - QuickJump: capitalize category badges (Recent, Starred, Project, Tool) and use " · " separator instead of parentheses for descriptions - Account switcher: show "Could not load accounts" instead of raw error - Detail: expose ctrl+d/ctrl+u scroll bindings in FullHelp - Date placeholders: remove hardcoded year, use "mar 15" style examples
jeremy
force-pushed
the
v1-ship-polish
branch
from
91c6400 to
212a7fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final polish pass before V1 ship. Addresses layout jank, visual inconsistencies, focus lifecycle gaps, a cross-account boost bug, and chrome discoverability issues. Builds on #155.
...→…across all loading/truncation, right-panel spinners fill their panel, rune-safe truncation in checkins, kanban empty/deferred column text, mystuff separator·separator, account switcher humanized error, Detail exposes scroll bindings in FullHelp, date placeholders drop hardcoded yearTest plan
make checkpasses clean…not...; right-panel spinners fill panel