fix(ci): pin udeps nightly to work around shellexpand breakage#827
Merged
fix(ci): pin udeps nightly to work around shellexpand breakage#827
Conversation
nightly-2026-02-22+ includes the str::as_str() stabilization (rust-lang/rust#151603) which shadows shellexpand 3.1.1's WstrExt::as_str() trait method, causing a compile error. Pin to nightly-2026-02-21 and invoke cargo-udeps directly since `just check-udeps` hardcodes `cargo +nightly`. Revert once rust-lang/rust#152963 lands in nightly.
Collaborator
✅ Heimdall Review Status
|
Contributor
Review SummaryNo issues found. This is a clean, minimal workaround for the upstream Rust nightly regression ( The change correctly mirrors what |
Collaborator
|
@niran can we add an issue to undo this when it's fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
udepsCI job tonightly-2026-02-21to work around a Rust nightly regression that breaksshellexpand3.1.1nightly-2026-02-22+stabilizedstr::as_str()as an inherent method (rust-lang/rust#151603), which shadows shellexpand'sWstrExt::as_str()trait method (returnsOption<&str>vs&str), causing a compile errorcargo +nightly-2026-02-21 udepsdirectly instead ofjust check-udepssince the justfile hardcodescargo +nightlyThis is currently blocking all merges to main — the last two pushes to main have failed on
udeps.Test plan
cargo +nightly-2026-02-22 check -p shellexpandfails with the type mismatch errorcargo +nightly-2026-02-21 check -p shellexpandcompiles cleanlycargo +nightly-2026-02-21 udeps --workspace --all-features --all-targetspasses ("All deps seem to have been used")