Skip to content

Comments

fix(flashblocks): add missing fields to rpc#624

Merged
danyalprout merged 1 commit intomainfrom
danyal/fix-pending-block-state
Jan 30, 2026
Merged

fix(flashblocks): add missing fields to rpc#624
danyalprout merged 1 commit intomainfrom
danyal/fix-pending-block-state

Conversation

@danyalprout
Copy link
Collaborator

Description

Add the missing fields to pending blocks. These are:

  1. Withdrawals, should always be empty array (but derived from FB's)
  2. Parent beacon block root, passed from builder
  3. Requests hash, should always be the empty hash

Context

Diff between op-reth and base-node-reth
image

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 30, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout marked this pull request as ready for review January 30, 2026 14:36
@danyalprout danyalprout requested review from haardikk21 and refcell and removed request for refcell January 30, 2026 14:37
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending another review

@danyalprout danyalprout added this pull request to the merge queue Jan 30, 2026
@danyalprout danyalprout removed this pull request from the merge queue due to a manual request Jan 30, 2026
@danyalprout danyalprout added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit e49679e Jan 30, 2026
16 checks passed
@danyalprout danyalprout deleted the danyal/fix-pending-block-state branch January 30, 2026 15:07
refcell pushed a commit that referenced this pull request Feb 18, 2026
## Summary
Implement `alloy_consensus::InMemorySize` trait for op consensus types.

## Motivation
Part of a multi-repo effort to move the `InMemorySize` trait from reth
into alloy (done in
[alloy#3656](alloy-rs/alloy#3656)). With the
trait now in alloy-consensus, reth can re-export it instead of defining
it locally. However, due to the orphan rule, the op type impls must live
in op-alloy.

## Changes
- Bump `alloy-consensus` minimum to 1.6.2 (which includes
`InMemorySize`)
- Add `InMemorySize` impls for: `OpTxType`, `TxDeposit`,
`OpDepositReceipt`, `OpReceipt`, `OpTypedTransaction`,
`OpPooledTransaction`, `OpTxEnvelope`

## Testing
```
cargo check -p op-alloy-consensus --all-features
cargo test -p op-alloy-consensus
```

Prompted by: mattsse

---------

Co-authored-by: Amp <[email protected]>
refcell pushed a commit that referenced this pull request Feb 18, 2026
## Summary
Implement `alloy_consensus::InMemorySize` trait for op consensus types.

## Motivation
Part of a multi-repo effort to move the `InMemorySize` trait from reth
into alloy (done in
[alloy#3656](alloy-rs/alloy#3656)). With the
trait now in alloy-consensus, reth can re-export it instead of defining
it locally. However, due to the orphan rule, the op type impls must live
in op-alloy.

## Changes
- Bump `alloy-consensus` minimum to 1.6.2 (which includes
`InMemorySize`)
- Add `InMemorySize` impls for: `OpTxType`, `TxDeposit`,
`OpDepositReceipt`, `OpReceipt`, `OpTypedTransaction`,
`OpPooledTransaction`, `OpTxEnvelope`

## Testing
```
cargo check -p op-alloy-consensus --all-features
cargo test -p op-alloy-consensus
```

Prompted by: mattsse

---------

Co-authored-by: Amp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants