Merged
Conversation
cspiel1
force-pushed
the
cisco_register_keep_alive
branch
from
ae537ff to
ebf60f2
Compare
sreimers
reviewed
Sep 9, 2020
.gitignore
Outdated
Member
There was a problem hiding this comment.
Please include only related changes within a pull a request and make a separat for these. Thanks.
Cisco phones send periodic REGISTER with Expires 0 to the SIP proxy.
After a registration failure a new instance of sipreg is allocated in order to send periodic Cisco REGISTER keep-alives. These keep-alives will detect when the SIP proxy becomes available again. The new function can be used to initialize failc, thus sipreg_failed() returns true initially.
Each digest challenge for a REGISTER should start without authorization header. This applies to periodic re-registration, for de-registration and also to Cisco REGISTER keep-alives.
The Cisco REGISTER keep-alives detect that a SIP proxy becomes available again. This has to be reported to the response handler in baresip.
cspiel1
force-pushed
the
cisco_register_keep_alive
branch
from
ebf60f2 to
f9af689
Compare
Contributor
Collaborator
Author
|
If fbregint is not set, nothing changes in the behavior. I tried my best to make this verifiable without testing. In addition I tested with use of up to 5 routr SIP server instances running in docker container. Test-secenarios:
|
Contributor
|
okay, please go ahead and merge to master if you agree... |
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Nov 28, 2020
= libre Changelog == [v1.1.0] - 2020-10-04 === Added - tls: functions to get the certificate issuer and subject [#18] - uri: Added path field to struct uri and its decode to uri_decode [#22] - tcp: add tcp_connect_bind [#24] - http: support bind to laddr in http_request [#24] - sipreg: support Cisco REGISTER keep-alives [#19] - sip: websocket support [#26] === Fixed - tls/openssl: fix X509_NAME win32/wincrypt.h conflict - dns: listen on IPv4 and IPv6 socket [#27] - main: fix/optimize windows file descriptors [#25] === Contributors (many thanks) - Alfred E. Heggestad - Christian Spielberger - Christoph Huber - Franz Auernigg - Juha Heinanen - Sebastian Reimers == [v1.0.0] - 2020-09-08 === Added - sip: add trace - sdp: sdp_media_disabled API function [#2] - tls: add tls_set_selfsigned_rsa [#6] - tls: add functions to verify server cert, purpose and hostname [#10] - http: client should set SNI [#10] - http: client should use tls functions to verify server certs, purpose and hostname [#10] - sipreg: add proxy expires field and get function [#13] - sipreg: make re-register interval configurable [#13] === Changed - debian: Automatic cleanup after building debian package === Fixed - Set SDK path (SYSROOT) using xcrun (fix building on macOS 10.14) - tcp: close socket on windows if connection is aborted or reset [#1] - rtmp: Fix URL path parsing (creytiv#245) - ice: various fixes [baresip/baresip#925] - openssl/tls: replace deprecated openssl 1.1.0 functions [#5] === Contributors (many thanks) - Alfred E. Heggestad - Christian Spielberger - Christoph Huber - Franz Auernigg - juha-h - Juha Heinanen - Richard Aas - Sebastian Reimers [#25]: baresip/re#25 [#27]: baresip/re#27 [#26]: baresip/re#26 [#19]: baresip/re#19 [#24]: baresip/re#24 [#22]: baresip/re#22 [#18]: baresip/re#18 [#13]: baresip/re#13 [#10]: baresip/re#10 [#6]: baresip/re#6 [#5]: baresip/re#5 [#2]: baresip/re#2 [#1]: baresip/re#1 [v1.0.0]: baresip/re@v0.6.1...v1.0.0 [v1.1.0]: baresip/re@v1.0.0...v1.1.0 [Unreleased]: baresip/re@v1.1.0...HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cisco REGISTER keep-alive is only a name for a periodic un-REGISTER, this is nothing more than a REGISTER with expires=0. A SIP proxy that is available answers to these un-REGISTER requests and thus the UA is able to track the availability of a proxy without having to register to it.
This is useful for a setup with a main SIP proxy and fallback proxies. Initially the registration is only done for the main proxy. The availability of the fallback proxy can be tracked by the Cisco REGISTER keep-alives.
The baresip/baresip#1083 is based on this PR.