skip overscan transformer for drivers with native overscan#292
Merged
Conversation
Ruida firmware applies its own overscan, so Rayforge's OverscanTransformer would double it up. Add a native_overscan driver capability flag (true for Ruida) and: - inject driver_native_overscan into the production settings dict - early-return in OverscanTransformer.run when the flag is set - show a banner and disable the overscan widget controls in the UI - add a warning icon to the post-processing expander header when an enabled overscan setting is unsupported, so the warning is visible without unfolding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruida firmware applies its own overscan, so Rayforge's OverscanTransformer would double it up.
native_overscandriver capability flag (True on RuidaDriver, False by default)driver_native_overscaninto production settings dict inprepare_task_settingsOverscanTransformer.runwhen the flag is setis_unsupported()method toStepComponentSettingsWidgetbase for extensibilityCloses the overscan portion of the driver feature gaps design.