Skip to content

Add macOS Tahoe (Liquid Glass-style) icons#285

Merged
knipknap merged 2 commits into
barebaric:mainfrom
LordImmaculate:main
Jun 10, 2026
Merged

Add macOS Tahoe (Liquid Glass-style) icons#285
knipknap merged 2 commits into
barebaric:mainfrom
LordImmaculate:main

Conversation

@LordImmaculate

@LordImmaculate LordImmaculate commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Hello

I added the new kind of macOS app icons (.icon instead of .icns) introduced with macOS Tahoe. This will make sure the icon looks great in clear or dark icon modes.

If the user is not on macOS 26+, it will fall back to the original .icns icon.

I also added .DS_Store to the .gitignore, this is a file that gets created for each folder automatically by Finder, which should not be committed.

@knipknap

knipknap commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! Looks like it is currently still failing:

  File "/Users/runner/work/rayforge/rayforge/.venv/lib/python3.11/site-packages/PyInstaller/building/icon.py", line 34, in normalize_icon_type
    raise FileNotFoundError(f"Icon input file {icon_path} not found")
FileNotFoundError: Icon input file /Users/runner/work/rayforge/rayforge/rayforge.icns not found

@LordImmaculate

LordImmaculate commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think the reason this happened is because the liquid glass icons were added in macOS 26 (so the command to add these too), but the GitHub actions were running on macOS 14 and 15. It worked on my computer running macOS 27, so I changed it in the actions.

@LordImmaculate

LordImmaculate commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Updating the runners to macOS 26 fixed it.

@knipknap

knipknap commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Awesome, Thanks!

@knipknap
knipknap merged commit 33f6687 into barebaric:main Jun 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LordImmaculate @knipknap