Skip to content

Fix manual laser control routing#259

Merged
knipknap merged 1 commit into
barebaric:mainfrom
heiserhorn:fix-manual-laser-control
May 25, 2026
Merged

Fix manual laser control routing#259
knipknap merged 1 commit into
barebaric:mainfrom
heiserhorn:fix-manual-laser-control

Conversation

@heiserhorn

Copy link
Copy Markdown
Contributor

Description
Fixes the manual laser control widget so laser on/off commands are sent to the machine currently assigned to the widget, instead of relying on the globally active config machine.

Previously, clicking the manual laser button could enqueue set_focus_power() against the wrong machine context, which meant the selected laser did not turn on from the widget.

Changes

  • Allow MachineCmd.set_power() and MachineCmd.set_focus_power() to accept an explicit machine.
  • Update LaserControlWidget to pass its assigned machine when turning the laser on or off.
  • Add focused tests for explicit machine routing in MachineCmd.

Verification

  • python3 -m compileall passed for changed files.
  • git diff --check passed.
  • Could not run pixi run lint or targeted pytest locally because pixi and pytest are not available in this environment.

@knipknap
knipknap merged commit aa05ab6 into barebaric:main May 25, 2026
29 checks passed
@knipknap

Copy link
Copy Markdown
Contributor

Thanks for the fix!

@heiserhorn
heiserhorn deleted the fix-manual-laser-control branch May 25, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants