Repository navigation
Preserve long precision in block-attack constant comparisons - #7223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockAttackInnerInterceptor converts integer constants to double before comparing them. Above 2^53, distinct long values can become equal: 9007199254740992 <> 9007199254740993 is classified as false even though it is true. This can let a constant-true UPDATE/DELETE condition pass the full-table check; the corresponding false equality is incorrectly rejected.
Compare two Long operands with Long.compare in all four parser variants. Floating-point and mixed-number comparisons retain their existing behavior.
The shared regressions cover UPDATE and DELETE, adjacent values above 2^53 and near Long.MAX_VALUE, all comparison operators, and AND/OR/NOT combinations. Restrictive column conditions remain permitted.
Validation against upstream e88aac9: