feat: add venue and schedule_item api#27
Merged
frostming merged 16 commits intobamboo-cms:mainfrom Mar 18, 2024
Merged
Conversation
frostming
reviewed
Dec 28, 2023
Signed-off-by: Frost Ming <[email protected]>
* ci: add workflow to test docker Signed-off-by: Frost Ming <[email protected]> * fix port Signed-off-by: Frost Ming <[email protected]> * copy .env Signed-off-by: Frost Ming <[email protected]> * wrong name Signed-off-by: Frost Ming <[email protected]> * use docker Signed-off-by: Frost Ming <[email protected]> --------- Signed-off-by: Frost Ming <[email protected]>
refactor: migrate to SQLAlchemy v2
frostming
reviewed
Jan 4, 2024
Contributor
frostming
left a comment
frostming
left a comment
There was a problem hiding this comment.
Added some comments, one must consider how the API will be used by the CMS to decide what should be included in the input and output.
| venue = Venue.query.get_or_404(venue_id) | ||
| db.session.delete(venue) | ||
| db.session.commit() | ||
| return "" |
Contributor
There was a problem hiding this comment.
Missing an endpoint to list all schedule_items associated to a specific venue, the route should be /<int:venue_id>/schedules
Contributor
|
Please resolve the conflicts, we have merged some changes recently |
frostming
requested changes
Jan 19, 2024
Co-authored-by: Frost Ming <[email protected]>
frostming
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.