fix: remove legacy type hint in models#25
Merged
frostming merged 1 commit intobamboo-cms:mainfrom Dec 28, 2023
yuxiaoy1:fix/models-type-hint
Merged
fix: remove legacy type hint in models#25frostming merged 1 commit intobamboo-cms:mainfrom yuxiaoy1:fix/models-type-hint
frostming merged 1 commit intobamboo-cms:mainfrom
yuxiaoy1:fix/models-type-hint
Conversation
Contributor
|
The problem of When we need cascade deletion, the children MUST be read, making it non-write-only. Can you advice on a proper way to achieve this with I've added some cascade deletion cases, you can pull the changes and see how they fail. |
Contributor
Author
|
I've made 3 updates here:
|
frostming
reviewed
Dec 28, 2023
180909
pushed a commit
to 180909/bamboo
that referenced
this pull request
Jan 2, 2024
refactor: migrate to SQLAlchemy v2
frostming
added a commit
that referenced
this pull request
Mar 18, 2024
* feat: add venue and schedule_item api * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refactor(git): ignore .idea and .vscode (#26) * feat: improve dockerfile and docker-compose Signed-off-by: Frost Ming <[email protected]> * ci: add workflow to test docker (#28) * ci: add workflow to test docker Signed-off-by: Frost Ming <[email protected]> * fix port Signed-off-by: Frost Ming <[email protected]> * copy .env Signed-off-by: Frost Ming <[email protected]> * wrong name Signed-off-by: Frost Ming <[email protected]> * use docker Signed-off-by: Frost Ming <[email protected]> --------- Signed-off-by: Frost Ming <[email protected]> * fix: remove legacy type hint in models (#25) refactor: migrate to SQLAlchemy v2 * fix test * update schema * update * Update backend/bamboo/blueprints/schedule_item.py Co-authored-by: Frost Ming <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix pytest --------- Signed-off-by: Frost Ming <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yongzeng Liu <[email protected]> Co-authored-by: Frost Ming <[email protected]> Co-authored-by: Frost Ming <[email protected]> Co-authored-by: Frank Yu <[email protected]> Co-authored-by: 180909 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicMappedis considered legacy: https://docs.sqlalchemy.org/en/20/orm/large_collections.html#sqlalchemy.orm.DynamicMapped, useWriteOnlyMappedinstead.