Fix deprecations from Symfony debug by shyim · Pull Request #66 · bamarni/composer-bin-plugin

shyim · 2022-02-16T09:43:10Z

09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::activate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::activate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\Capable::getCapabilities()" might add "array" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\Capable::getCapabilities()" might add "array" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::deactivate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::deactivate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::uninstall()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::uninstall()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]

theofidry

Thanks for the PR!

theofidry · 2022-02-16T16:25:07Z

Released as part of 1.4.2!

shyim added 3 commits February 16, 2022 10:41

add typehint to fix deprecation

48fbfa7

fix for PHP 5

f202062

Update Plugin.php

ceff4bc

theofidry reviewed Feb 16, 2022

View reviewed changes

Comment thread src/Plugin.php

theofidry merged commit f7fb03e into bamarni:master Feb 16, 2022

mimmi20 mentioned this pull request Feb 18, 2022

add forward mode #67

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix deprecations from Symfony debug#66

Fix deprecations from Symfony debug#66
theofidry merged 3 commits into
bamarni:masterfrom
shyim:master

shyim commented Feb 16, 2022

Uh oh!

theofidry left a comment

Uh oh!

Uh oh!

theofidry commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shyim commented Feb 16, 2022

Uh oh!

theofidry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theofidry commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants