Skip to content

Add PHPStan to CI#117

Merged
theofidry merged 7 commits into
bamarni:masterfrom
szepeviktor:patch-1
Jul 10, 2022
Merged

Add PHPStan to CI#117
theofidry merged 7 commits into
bamarni:masterfrom
szepeviktor:patch-1

Conversation

@szepeviktor
Copy link
Copy Markdown
Contributor

@szepeviktor szepeviktor commented Jul 10, 2022

Let's see the output! 🤩

From #109

@szepeviktor szepeviktor marked this pull request as ready for review July 10, 2022 18:31
Copy link
Copy Markdown
Collaborator

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal!

Comment thread .github/workflows/tests.yaml Outdated
Comment thread .github/workflows/tests.yaml Outdated
Comment thread .github/workflows/tests.yaml Outdated
Comment thread .github/workflows/tests.yaml Outdated
@szepeviktor
Copy link
Copy Markdown
Contributor Author

All green 🍏

@szepeviktor
Copy link
Copy Markdown
Contributor Author

@theofidry This is the mother of all GHA configs.
https://github.com/ergebnis/php-package-template/tree/main/.github/workflows
If you have a bit of time please take a look at it.

@theofidry theofidry merged commit 5cc3b4f into bamarni:master Jul 10, 2022
@theofidry
Copy link
Copy Markdown
Collaborator

Thank you @szepeviktor! :)

@szepeviktor szepeviktor deleted the patch-1 branch July 10, 2022 22:19
@szepeviktor
Copy link
Copy Markdown
Contributor Author

You're welcome. @theofidry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants