64 bit LEB128 constant encoding #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
reviewed
Feb 6, 2018
| } | ||
| export function test(): i32 { | ||
| return number(): i32; | ||
| } | ||
| `).then(result => t.is(result.instance.exports.test(), 0)); | ||
| `).then(result => t.is(result.instance.exports.test(), 42)); |
There was a problem hiding this comment.
Just for my information, the test function is doing a conversion from i64 to i32? Is this your technique to test 64 bits ints in js?
I like how TypeScript explicitly does it: number() as i32 (just an idea).
There was a problem hiding this comment.
Yes, but 64-bit nums are tested indirectly. If that encoding failed, then the data would be garbage or the program wouldn't compile at runtime.
The : is a type cast operator borrowed from flow
ballercat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant encoding for 64-bit integers/floats is non-existent and is done via runtime typecasts instead. This is work to fix that.
Fixing some things while here.