[WIP] Object access dot operator #37
Conversation
|
Thanks for opening up a WIP PR for this, I think you are on a good track. I took a look at the code. I see what you did here, and it makes sense. I would prefer for us not to create another Token type for this. The dot We should add it to the list of valid RE:
I'm not 100% on what do you mean by |
|
By |
|
It still doesn't make it a non binary operator |
|
Don't worry you did not cause a regression. Nested Objects are not yet supported so |
| export function accessIdentifier(ctx: Context): Node { | ||
| const node = ctx.startNode(); | ||
| // We're removing first character which is access dot operator | ||
| node.value = ctx.token.value.substring(1, ctx.token.value.length); |
There was a problem hiding this comment.
- Second argument to
substringis unnecessary if you need the rest of the string like here - The comment says we are removing the first character but https://github.com/ballercat/walt/pull/37/files#diff-94eebbd7c72a61803345c949037690d8R75 pushes the
.as an individual token, so I'm not sure how this works.
There was a problem hiding this comment.
I've removed it between first and second commit so I don't know why this file is still present.
| // if (value === ":" && previous.type === Syntax.Pair) break; | ||
| consume(); | ||
| } | ||
| }; | ||
|
|
||
| const processPunctuator = () => { | ||
| switch (ctx.token.value) { | ||
| case ".": | ||
| operators.push(ctx.token); |
There was a problem hiding this comment.
Why are you handling the dot separately? It should be parsed as part of the default case for operators.
| operands.push(accessIdentifier(ctx)); | ||
| eatUntil(isLSqrBracket); | ||
| consume(); | ||
| eatFunctionCall = false; |
There was a problem hiding this comment.
I'd like us to avoid doing this. Feel free to email me if you're stuck/need some more info on the parser implementation.
|
Closing in favor of #47 |
Attempt to resolve #28.
There is probably some work but I'm creating an issue to gain some feedback about the direction I'm heading. I don't know if it's correct because I almost don't know the compiler but the first version seems to work just fine. I've also was trying to create nested objects but it seems to not work for
ArraySubscriptso it's not working forAccessIdentifier