Skip to content

Conversation

@ballercat
Copy link
Owner

#29

  • Add eslint validation script
  • Flowtype rules
  • ran eslint --fix

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.725% when pulling c41ac54 on validation into 314a53e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.725% when pulling c4750a3 on validation into 314a53e on master.

@ballercat ballercat merged commit 882cd4b into master Dec 16, 2017
@ballercat ballercat deleted the validation branch December 16, 2017 21:37
@ForsakenHarmony
Copy link
Contributor

do you not want dangling commas? they're good for git diffs

@ballercat
Copy link
Owner Author

They do make diffs slightly better when adding to an existing list, but I don't think that scenario is significant enough to optimize.

I don't use them, and I already wrote so much code that I'm airing on the side of consistency.

@ForsakenHarmony
Copy link
Contributor

pretty sure eslint can fix it

@ballercat
Copy link
Owner Author

I would be open to them I guess. I don't feel that strongly about using them or not, and it's just not part of my current workflow. I can see that there might be a marginal benefit for not a lot of effort, so if you want to --fix them and submit the changes then that's fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants