Use codeactions & textedits to update the document text#5
Closed
Use codeactions & textedits to update the document text#5
Conversation
This fixes further race conditions. It's a little hacky as I have to use temp files to get formatted file contents. Also the auto-fix on save doesn't work the first time you run it, and not sure why.
Owner
Author
|
Note this PR is a POC and I probably won't merge it. See https://gist.github.com/badsyntax/d6b3c0676d9f99a9784327e5004d889d for reasons for this approach. A better approach would be to get spotless to write to stdout. Related PR: diffplug/spotless#568 |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes further race conditions. It's a little hacky as I have to use temp files to get formatted file contents, and update the vscode config to ignore the temp files.
Also the auto-fix on save doesn't work the first time you run it, and not sure why.