fix: remove footer dark style to enable theme switching #11431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Author
Member
|
Could you please share screenshots validating the change? |
Contributor
Author
ScreenShots:In Light:
In Dark:
|
PyvesB
approved these changes
Oct 19, 2025
Member
PyvesB
left a comment
PyvesB
left a comment
There was a problem hiding this comment.
Thanks! Looks reasonable to me, let's ship it.
This was referenced Oct 19, 2025
Contributor
Author
|
Thanks for merging it :) |
jNullj
pushed a commit
to jNullj/shields-fun-fork
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11417
Description
This PR removes the hardcoded style: 'dark' from the footer configuration to enable automatic theme switching between light and dark modes.
Problem
When switching between light and dark modes, the footer color remained dark even in light mode, creating visual inconsistency and breaking design harmony.
Solution
As suggested by maintainer @PyvesB, simply removing the style: 'dark' line allows the footer to dynamically adapt its colors according to the selected theme.
Changes Made
Removed style: 'dark' from frontend/docusaurus.config.cjs (line 91)
Testing
The footer now automatically switches between light and dark themes, ensuring consistent UI experience across both modes.